Add hiera_hash support for limits fragments #106
Conversation
| @@ -837,6 +838,19 @@ | |||
| validate_re($sshd_pam_access, $valid_pam_access_values, | |||
| "pam::sshd_pam_access is <${sshd_pam_access}> and must be either 'required', 'requisite', 'sufficient', 'optional' or 'absent'.") | |||
|
|
|||
| case type($limits_fragments_hiera_merge) { | |||
There was a problem hiding this comment.
The type() function is deprecated as type is now a reserved word. Check out the is_* functions.
https://github.com/puppetlabs/puppetlabs-stdlib/tree/4.2.0#is_string
|
Great work @jwennerberg Glad to see some code from you again :) |
|
about time I got back to some coding :) Let me know what you think and if/when to rebase. |
|
@ghoneycutt did you have a chance to look at this? |
| if is_bool($limits_fragments_hiera_merge) == true { | ||
| $limits_fragments_hiera_merge_real = $limits_fragments_hiera_merge | ||
| } else { | ||
| validate_re($limits_fragments_hiera_merge, '^(true|false)$', "pam::limits_fragments_hiera_merge may be either 'true' or 'false' and is set to <${limits_fragments_hiera_merge}>.") |
There was a problem hiding this comment.
don't think this is needed since str2bool will sort it out
|
you mean something like that? |
| @@ -837,6 +838,9 @@ | |||
| validate_re($sshd_pam_access, $valid_pam_access_values, | |||
| "pam::sshd_pam_access is <${sshd_pam_access}> and must be either 'required', 'requisite', 'sufficient', 'optional' or 'absent'.") | |||
|
|
|||
| $limits_fragments_hiera_merge_real = str2bool($limits_fragments_hiera_merge) | |||
There was a problem hiding this comment.
I think you need a conditional around this in case the variable is already a boolean.
something like
if is_string($limits_fragments_hiera_merge) == true {
$limits_fragments_hiera_merge_real = str2bool($limits_fragments_hiera_merge)
} else {
$limits_fragments_hiera_merge_real = $limits_fragments_hiera_merge
}
validate_bool($limits_fragments_hiera_merge_real)
jwennerberg
force-pushed
the
hiera_hash
branch
3 times, most recently
from
788117c
to
6a88d7c
Compare
|
@ghoneycutt I've rebased this against master |
Add hiera_hash support for limits fragments
|
Released in v2.17.0 Thanks @jwennerberg |
No description provided.