Add template for performing custom sshd pam config

[boandersson]

Specific use case is to be able to supply options to pam_vas3 that are
specifically needed (and should only be configured) for sshd to resolv
intermittent ssh login failures with QAS.

[ghoneycutt]

Thanks @boandersson

@Phil-Friderici what do you think?

[ghoneycutt]

we probably need some fixtures around this for the spec testing

[Phil-Friderici]

True if the sequence does matter here. Looking at the short result of the existing tests I would recommend to use a variable instead of adding a a fixture file. Like here [1].

[1] https://github.com/ghoneycutt/puppet-module-bind/blob/master/spec/classes/init_spec.rb#L127-L149

[boandersson]

Agree that the current tests aren't that useful, esp since the sequence of each section is very important... I'll have a look.

[boandersson]

Took the route with a variable as suggested by @Phil-Friderici , let me know what you think

[ghoneycutt]

@boandersson would it be possible to just update the default VAS entries in the code?

[Phil-Friderici]

An alternative approach would be to bring all sshd.$osfamily.erb template content into the code. This would become a bigger refactoring of the functionality. Which I would only do on a major version update.

So I can understand why @boandersson chose this way.

[ghoneycutt]

I'm going to defer to @Phil-Friderici on this. When he gives the thumbs up, I'll merge and release.

[Phil-Friderici]

@boandersson Think we only need to agree how detailed we want to test here. After that, please squash all commits into one for a nice commit history :)

[boandersson]

Added test updates from @Phil-Friderici. Let me know what you think before I squash any commits

[Phil-Friderici]

From my perspective this is complete.
@boandersson please squash it into one commit.
@ghoneycutt please have a second look and merge it if you are ok with it too.

[Phil-Friderici]

@boandersson thanks for squashing
@ghoneycutt looks good to me now :)

[ghoneycutt]

Thank you both!

[ghoneycutt]

Released in v2.27.0

[boandersson]

Thanks for code review and merge @ghoneycutt !