Add SLES10.x support #96
Conversation
|
|
||
| - *Default*: undef | ||
|
|
||
| config_file_source |
There was a problem hiding this comment.
I don't think we need to support source, since we support contents, unless you really want this. Removing will make testing easier.
propyless
force-pushed
the
sles10_support
branch
2 times, most recently
from
4001a92
to
a0f2ec2
Compare
|
Hello! Phil has written the spec tests and checks source and contents etc. Since the support for source is already in the code it feels a bit unnecessary to remove it for the sake of simplicity. I've updated the README as it the description was a bit thin as pointed out by you :). Hopefully this travis build will pass =) |
| @@ -355,6 +355,19 @@ Mode for config_file. | |||
|
|
|||
| - *Default*: '0640' | |||
|
|
|||
| config_file_contents | |||
There was a problem hiding this comment.
The word contents suggests the contents of the file, such as providing all of the contents, when this is actually an array of lines. For clarity, could this be changed to config_file_lines ?
propyless
force-pushed
the
sles10_support
branch
from
a0f2ec2
to
41f42cb
Compare
|
Yes I can agree with you on that as well. Fixed. =) |
|
@Phil-Friderici This look good to you? |
SLES10.x does not support limits fragments as it does not traverse the limits.d catalog.
propyless
force-pushed
the
sles10_support
branch
from
41f42cb
to
570c9e5
Compare
|
@ghoneycutt: yes functionality looks good to me. Maybe the helper variable $content could be renamed to $config_file_content, but that's not a variable that users come in touch with. |
|
@propyless: you are fixing fast ;) |
|
Whats a guy gotta do to get a merge around here :P |
|
Lulz. Looks good, though I'm not merging anything so late at night. Will check it out again tomorrow. |
|
@ghoneycutt Thanks & have a good night ! |
|
Sleep tight |
|
Released in v2.14.0 |
|
Thanks gents |
|
@ghoneycutt @propyless was a pleasure :) |
|
Thanks all =). |
SLES10.x does not support limits fragments as
it does not traverse the limits.d catalog.