Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary spread, use {} as triggerMap #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreyvolokitin
Copy link

Hello. There is a problem in IE11 which needs additional polyfilling in order to work. But I also discovered that it causes errors in IE11 even with polyfills and Babel transpilation.

I found out that polyfilling Array.from is actually unnecessary: the code containing it is generated by Babel transpilation, and caused by spread operators used in the code. But what I found is that spread operators can be either easily removed (in case of converting NodeList to Array), or aren't needed at all.

I also changed triggerMap to be an object instead of array.

@andreyvolokitin
Copy link
Author

BTW, by removing the spread operator we can make Micromodal more "micro" by not relying on additional spread polyfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant