Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cache): add Cache-Control middleware and update .env.example #90

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

abdelaziz-mahdy
Copy link
Contributor

this works with vercel so its very nice to use

Copy link

vercel bot commented Dec 22, 2024

@abdelaziz-mahdy is attempting to deploy a commit to the ghoshritesh12's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@WBRK-dev WBRK-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but code looks good.

@abdelaziz-mahdy
Copy link
Contributor Author

Didn't test, but code looks good.

Adding the headers makes the calls cached by vercel edge , which is awesome, the readme may add some info about it, but I may need some guidance on the format required

@ghoshRitesh12
Copy link
Owner

@abdelaziz-mahdy thank you so much for this amazing PR, there are a couple of changes, not logical but simple stylistic changes that I'd like you to make to maintain consistency is all 😄.

@abdelaziz-mahdy
Copy link
Contributor Author

@abdelaziz-mahdy thank you so much for this amazing PR, there are a couple of changes, not logical but simple stylistic changes that I'd like you to make to maintain consistency is all 😄.

all good from my side, i like this project so anything that will make it easier to maintain or help other people is on my table <3

@ghoshRitesh12
Copy link
Owner

@abdelaziz-mahdy thank you so much for this amazing PR, there are a couple of changes, not logical but simple stylistic changes that I'd like you to make to maintain consistency is all 😄.

all good from my side, i like this project so anything that will make it easier to maintain or help other people is on my table <3

@abdelaziz-mahdy thank you so much for understanding, also I've mentioned the required changes.

@abdelaziz-mahdy
Copy link
Contributor Author

@ghoshRitesh12 i am not sure, but did you not submit the review comments? i cant see it :(

@ghoshRitesh12
Copy link
Owner

@ghoshRitesh12 i am not sure, but did you not submit the review comments? i cant see it :(

Yeah I did

@abdelaziz-mahdy
Copy link
Contributor Author

abdelaziz-mahdy commented Dec 23, 2024

@ghoshRitesh12 i am not sure, but did you not submit the review comments? i cant see it :(

Yeah I did

can you redo it, i cant see them, a screenshot will do for me, but github is showing me nothing currently

@ghoshRitesh12
Copy link
Owner

@ghoshRitesh12 i am not sure, but did you not submit the review comments? i cant see it :(

Yeah I did

can you redo it, i cant see them, a screenshot will do for me, but github is showing me nothing currently

Here:

IMG_20241223_125145.jpg

@abdelaziz-mahdy
Copy link
Contributor Author

@ghoshRitesh12 i am not sure, but did you not submit the review comments? i cant see it :(

Yeah I did

can you redo it, i cant see them, a screenshot will do for me, but github is showing me nothing currently

Here:

IMG_20241223_125145.jpg

note its pending, which means it was not pushed to github, this is why its not showing to me :)

Copy link
Owner

@ghoshRitesh12 ghoshRitesh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, here they are

.env.example Show resolved Hide resolved
src/config/cache_control_middleware.ts Outdated Show resolved Hide resolved
src/config/cache_control_middleware.ts Outdated Show resolved Hide resolved
@abdelaziz-mahdy
Copy link
Contributor Author

done.

@ghoshRitesh12 ghoshRitesh12 merged commit 2e93990 into ghoshRitesh12:main Dec 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants