-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cache): add Cache-Control middleware and update .env.example #90
feat(cache): add Cache-Control middleware and update .env.example #90
Conversation
@abdelaziz-mahdy is attempting to deploy a commit to the ghoshritesh12's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test, but code looks good.
Adding the headers makes the calls cached by vercel edge , which is awesome, the readme may add some info about it, but I may need some guidance on the format required |
@abdelaziz-mahdy thank you so much for this amazing PR, there are a couple of changes, not logical but simple stylistic changes that I'd like you to make to maintain consistency is all 😄. |
all good from my side, i like this project so anything that will make it easier to maintain or help other people is on my table <3 |
@abdelaziz-mahdy thank you so much for understanding, also I've mentioned the required changes. |
@ghoshRitesh12 i am not sure, but did you not submit the review comments? i cant see it :( |
Yeah I did |
can you redo it, i cant see them, a screenshot will do for me, but github is showing me nothing currently |
Here: |
note its pending, which means it was not pushed to github, this is why its not showing to me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, here they are
done. |
this works with vercel so its very nice to use