Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding filesystems to xpm_package_category #39

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Dec 6, 2024

Resolve this issue seen in ghostbsd/issues#195

Summary by Sourcery

Add a new 'filesystems' category to the xpm_package_category function and rename the function for consistency. Update the software version to 2.0 in setup.py.

New Features:

  • Add 'filesystems' category to the xpm_package_category function.

Enhancements:

  • Rename function xpmPackageCategory to xpm_package_category for consistency.

@ericbsd ericbsd self-assigned this Dec 6, 2024
@ericbsd ericbsd requested review from a team as code owners December 6, 2024 23:55
Copy link

sourcery-ai bot commented Dec 6, 2024

Reviewer's Guide by Sourcery

This PR adds a new 'filesystems' category icon to the XPM package categories and includes some minor code improvements. The changes primarily involve adding new XPM image data for the filesystems icon, renaming a function to follow Python naming conventions, and bumping the version number.

Class diagram for the updated xpm_package_category function

classDiagram
    class xpm_package_category {
        +all: List
        +filesystems: List
        +finance: List
    }
    note for xpm_package_category "Renamed from xpmPackageCategory to follow Python naming conventions"
Loading

File-Level Changes

Change Details Files
Added new XPM icon data for the filesystems category
  • Added new XPM color palette with 135 colors
  • Added pixel data for a 20x20 filesystem icon
software_station_xpm.py
Updated function name to follow Python naming conventions
  • Renamed 'xpmPackageCategory' to 'xpm_package_category' using snake_case
software_station_xpm.py
Bumped software version
  • Updated default version from '1.7' to '2.0'
setup.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The version bump from 1.7 to 2.0 seems too aggressive for these changes. Consider using a minor version increment instead (e.g. 1.8).
  • Please provide more context in the PR description about what problem this solves, rather than just referencing the issue number.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

software_station_xpm.py Show resolved Hide resolved
@ericbsd ericbsd merged commit 1814fc2 into master Dec 7, 2024
1 check passed
@ericbsd ericbsd deleted the ghostbsd/issues#195 branch December 7, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant