Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed get_default_repo_url #51

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Fixed get_default_repo_url #51

merged 2 commits into from
Aug 1, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Aug 1, 2024

Summary by Sourcery

Fix the get_default_repo_url function to correctly filter for the latest repository URL and update the version number in setup.py from 5.4 to 5.5.

Bug Fixes:

  • Fix the get_default_repo_url function to correctly filter for the latest repository URL.

Enhancements:

  • Update the version number in setup.py from 5.4 to 5.5.

@ericbsd ericbsd self-assigned this Aug 1, 2024
@ericbsd ericbsd requested review from a team as code owners August 1, 2024 23:42
Copy link
Contributor

sourcery-ai bot commented Aug 1, 2024

Reviewer's Guide by Sourcery

This pull request updates the version number in setup.py and refines the command used in get_default_repo_url function to ensure it retrieves the latest repository URL.

File-Level Changes

Files Changes
setup.py
src/updateHandler.py
Updated versioning and refined repository URL retrieval command.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you provide more context on why the additional 'grep latest' was added to the get_default_repo_url function? This change might affect the function's behavior in unexpected ways.
  • Consider removing the commented out 'use_scm_version=True' line in setup.py if it's not being used, to keep the code clean.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

setup.py Show resolved Hide resolved
@ericbsd ericbsd merged commit f421997 into master Aug 1, 2024
1 check passed
@ericbsd ericbsd deleted the get_default_repo_url branch August 1, 2024 23:44
@ericbsd ericbsd added the bug label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant