Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed assert and adding code to fetch PKGBASE to add a progress step #52

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Aug 2, 2024

Summary by Sourcery

Introduce a new function to fetch the GhostBSD-base package and update the version number in setup.py to 5.6. Additionally, clean up the setup.py file by removing an unused commented-out line.

New Features:

  • Add a new function fetch_ghostbsd_pkgbase to fetch the GhostBSD-base package.

Chores:

  • Update version number in setup.py from 5.5 to 5.6.
  • Remove commented-out use_scm_version line from setup.py.

@ericbsd ericbsd self-assigned this Aug 2, 2024
@ericbsd ericbsd requested review from a team as code owners August 2, 2024 17:48
Copy link
Contributor

sourcery-ai bot commented Aug 2, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new function fetch_ghostbsd_pkgbase in src/updateHandler.py to fetch the GhostBSD-base package, enhancing the update process by adding a progress step. Additionally, the version number in setup.py has been updated from 5.5 to 5.6, and an obsolete commented-out line has been removed.

File-Level Changes

Files Changes
src/updateHandler.py
setup.py
Introduced a new function to fetch the GhostBSD-base package and updated the version number to 5.6.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The new fetch_ghostbsd_pkgbase function looks useful, but could you provide some context on how it will be integrated into the update process?
  • The docstring for fetch_ghostbsd_pkgbase is currently identical to install_ghostbsd_pkgbase. Please update it to accurately describe the fetching process.
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

src/updateHandler.py Show resolved Hide resolved
src/updateHandler.py Outdated Show resolved Hide resolved
@ericbsd ericbsd merged commit c45ecda into master Aug 2, 2024
@ericbsd ericbsd deleted the fixed-restored-files branch August 2, 2024 17:53
@ericbsd ericbsd added the bug label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant