Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/partial localization object #152

Closed

Conversation

cainthebest
Copy link
Contributor

Checklist

  • Related issue:
  • Changesets done

Body

I had a issue where the nameLocalizations & descriptionLocalizations types were Record<enum, string> meaning all enum members were required. This pr just changes the type to Partial<Record<enum, string>> so that all enum members are optional

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2023

⚠️ No Changeset found

Latest commit: 2516045

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "dev" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@cainthebest cainthebest changed the title Feat/partial localization object Fix/partial localization object Feb 3, 2023
@cainthebest cainthebest closed this Feb 3, 2023
@cainthebest cainthebest deleted the feat/partial-localization-object branch February 3, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant