Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forexlive.com #379

Closed
DavidLee3835 opened this issue Nov 7, 2023 · 15 comments
Closed

Forexlive.com #379

DavidLee3835 opened this issue Nov 7, 2023 · 15 comments
Labels
type/ad-blocking Issues with Ad-Blocking

Comments

@DavidLee3835
Copy link

I'm using ghostery chrome extension.
Forexlive.com is broken when ghostery's AdBlock feature is active.

When ghostery is not active

ghostery off

When ghostery is active

ghostery on

@GRadziejewski GRadziejewski self-assigned this Dec 6, 2023
@GRadziejewski GRadziejewski added the type/ad-blocking Issues with Ad-Blocking label Dec 6, 2023
@GRadziejewski GRadziejewski moved this to Confirmed in Broken Page Reports Dec 6, 2023
@GRadziejewski
Copy link
Contributor

I can reproduce the described issue.

Versions:

Browser: Firefox 120.0
OS: Windows 10 Pro 
GBE 8.11.1

Browser: Chrome 119.0.6045.125
OS: Windows 10 Pro 
GBE 8.12.4

Browser: Opera One 105.0.4970.21
OS: Windows 10 Pro
GBE 8.12.4

Browser: Edge 119.0.2151.97 
OS: Windows 10 Pro 
GBE 8.12.4

@GRadziejewski GRadziejewski removed their assignment Dec 6, 2023
@GRadziejewski
Copy link
Contributor

Problem still occurs. (Chrome on the right)

image

Problem occurs on:

Browser: Chrome 120.0.6099.130
OS: Windows 10 Pro 
GBE 8.12.6

Cannot reproduce on:

Browser: Firefox 121.0
OS: Windows 10 Pro 
GBE 8.12.5

Browser: Safari 17.2.1 (19617.1.17.11.12)
OS: MacOS Ventura 14.2
GBE 10.2.6

seia-soto added a commit to seia-soto/userscripts that referenced this issue Dec 29, 2023
@seia-soto
Copy link
Member

seia-soto commented Dec 29, 2023

By seeing the screenshots by OP, I see AdShield is powering this website.

@GRadziejewski can you install the userscript: AdShield Defuser from the following website and retry?: https://seia-soto.github.io/userscripts/
Currently, the adblocker library embedded in Ghostery can't handle AdShield properly. Also, if you find the similar websites in future: please mention me and @piquark6046 .

@piquark6046 keep eyes on this please. + You'll need to upgrade defuser library to version 0.0.14 to build properly.

@seia-soto
Copy link
Member

seia-soto commented Dec 29, 2023

Btw, I cannot see adshield on my side.

Version 118.0.5993.117 (Official Build, ungoogled-chromium) (arm64)

@piquark6046
Copy link

piquark6046 commented Dec 29, 2023

Btw, I cannot see adshield on my side.

Same.
I will check that the Ad-Shield appears if I configure Windows 11 23H2 with the Korean language pack.

@piquark6046
Copy link

piquark6046 commented Dec 29, 2023

You'll need to upgrade defuser library to version 0.0.14 to build properly.

Well, As i remember, when i apply the library 0.0.13, it does not work correctly at some websites with Violentmonkey.

@seia-soto
Copy link
Member

seia-soto commented Dec 29, 2023

You'll need to upgrade defuser library to version 0.0.14 to build properly.

Well, As i remember, when i apply the library 0.0.13, it does not work correctly at some websites with Violentmonkey.

Please, add some details and send me an email: seia@outlook.kr . Also, you may extract caches again. About the versioning, I actually took one of my packages down from NPM. You won't able to build 0.0.13 unless you remove buffertly from deps.

@piquark6046
Copy link

piquark6046 commented Dec 29, 2023

I can reproduce without EasyPrivacy and AdGuard Tracking protection filter.

Screenshots

Screenshot from 2023-12-29 11-10-47
Screenshot from 2023-12-29 11-11-28

Environment:
ProtonVPN KR#15

piquark6046 added a commit to List-KR/microShield that referenced this issue Dec 29, 2023
@piquark6046
Copy link

After installing microShield userscript, the Ad-Shield script creates a popup alert saying "don't block 07c225f3.online" without breaking CSS of the webpage.

@piquark6046
Copy link

piquark6046 commented Dec 29, 2023

With your userscript, It seems that the popup alert does not appear.

@piquark6046
Copy link

piquark6046 commented Jan 5, 2024

#379 (comment)
Fixed by List-KR/microShield#57.

@GRadziejewski GRadziejewski mentioned this issue Jan 31, 2024
@GRadziejewski
Copy link
Contributor

On Chrome, I still have a problem:
image

Browser: Chrome 121.0.6167.162
OS: Windows 10 Pro 
GBE 8.12.6

On the other hand, on Safari I have plenty of ads:
Screenshot 2024-02-21 at 16 34 34

Browser: Safari 17.3.1 (19617.2.4.11.12)
OS: macOS Ventura 14.3.1
GBE 10.2.11

@piquark6046
Copy link

@GRadziejewski
#379 (comment)

Does Installing microShield userscript not help?

@GRadziejewski
Copy link
Contributor

I have checked this on the latest version of our extension in these browsers, if a fix is not live, I assume this is why it is not working. Am I missing something here?

@seia-soto
Copy link
Member

You're not missing anything. It should not work with plain Ghostery installation.

@seia-soto seia-soto closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/ad-blocking Issues with Ad-Blocking
Projects
None yet
Development

No branches or pull requests

4 participants