Summary View Bug Fixes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophertino
approved these changes
Apr 18, 2018
IAmThePan
force-pushed
the
features/summary-view-bug-fixes
branch
from
8dea74f to
2b71d23
Compare
christophertino
pushed a commit
that referenced
this pull request
Mar 17, 2021
…-2305) (#675) * Expand toggle and select plus plan if user is basic and selects ghostery search * Make ghostery glow icon bigger in select default search modal * Move ghostery logo on search option selection container a little to the left * Remove expansion by default * Update logo sizes on choose default search view * Adjust sizing for Yahoo, Startpage, and Bing logos in search selection modals to better match Zeplins * Increase chance user object is available before choose plan view render. Show expanded view if user picked Glow to match expected UX. Add TODOs so we remember to update AccountReducer to help distinguish between no user present and user not fetched yet * Factor out option card checkmark item rendering to a helper to reduce duplication. * Update test snapshots * Refactor choose plan view plan card feature copy rendering to a helper to reduce duplication * Factor user status checks in select plan view out to helpers to reduce duplication and bug surface * Move setting of default plan in plan select view to componentDidMount to avoid using setTimeout to setState in constructor * Revised setDefaultPlan() logic in ChoosePlanView to make sure everything renders as expected when user is Plus or Premium Co-authored-by: wlycdgr <ilya.zarembsky@gmail.com>
chrmod
pushed a commit
that referenced
this pull request
Jul 28, 2022
…-2305) (#675) * Expand toggle and select plus plan if user is basic and selects ghostery search * Make ghostery glow icon bigger in select default search modal * Move ghostery logo on search option selection container a little to the left * Remove expansion by default * Update logo sizes on choose default search view * Adjust sizing for Yahoo, Startpage, and Bing logos in search selection modals to better match Zeplins * Increase chance user object is available before choose plan view render. Show expanded view if user picked Glow to match expected UX. Add TODOs so we remember to update AccountReducer to help distinguish between no user present and user not fetched yet * Factor out option card checkmark item rendering to a helper to reduce duplication. * Update test snapshots * Refactor choose plan view plan card feature copy rendering to a helper to reduce duplication * Factor user status checks in select plan view out to helpers to reduce duplication and bug surface * Move setting of default plan in plan select view to componentDidMount to avoid using setTimeout to setState in constructor * Revised setDefaultPlan() logic in ChoosePlanView to make sure everything renders as expected when user is Plus or Premium Co-authored-by: wlycdgr <ilya.zarembsky@gmail.com>
chrmod
pushed a commit
that referenced
this pull request
Jul 29, 2022
…-2305) (#675) * Expand toggle and select plus plan if user is basic and selects ghostery search * Make ghostery glow icon bigger in select default search modal * Move ghostery logo on search option selection container a little to the left * Remove expansion by default * Update logo sizes on choose default search view * Adjust sizing for Yahoo, Startpage, and Bing logos in search selection modals to better match Zeplins * Increase chance user object is available before choose plan view render. Show expanded view if user picked Glow to match expected UX. Add TODOs so we remember to update AccountReducer to help distinguish between no user present and user not fetched yet * Factor out option card checkmark item rendering to a helper to reduce duplication. * Update test snapshots * Refactor choose plan view plan card feature copy rendering to a helper to reduce duplication * Factor user status checks in select plan view out to helpers to reduce duplication and bug surface * Move setting of default plan in plan select view to componentDidMount to avoid using setTimeout to setState in constructor * Revised setDefaultPlan() logic in ChoosePlanView to make sure everything renders as expected when user is Plus or Premium Co-authored-by: wlycdgr <ilya.zarembsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-955: Update Smart Blocking icon on Tracker List
GH-954: Fix spelling error for Anti-Tracking ON notification
@christophertino Please approve