Refactor, document Java API takeoffer bots #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TakeBestPricedOfferTo*Btc needed to be split up so they are specific to fiat offers, and this change adds new TakeBestPricedOfferTo*Xmr bots just for XMR. This simplifies the the non-bsq-swap bots; documenting, coding, configuring, and logging the taking of both fiat and xmr (altcoin) offers in the same bots was getting confusing, and that's going to turn away potential users. This refactoring means there are six bots now, and it forced considerable refactoring in all of them. This commit is the bulk of the work for the PR, but there will be more changes after everything is tested again, and comments are adjusted.
Hideous, but navigable.
Links to xmr bot src added to the PR branch will work after PR is merged.
ghubstan
changed the title
ghubstan
changed the title
ghubstan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code, configuration and documentation is simplified with this refactoring. Two bots could do everything to take BTC/BSQ/XMR offers, but we want the script configs to be less complex, and the code more readable for people who aren't Java devs -- who might want to port them to other gRPC supported language bindings.
Note: there are some README links pointing back to this
split-up-take-btc-offer-botsbranch. They will be changed to point to themainbranch when/if this PR is near approval.