Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs related to margin config #7

Merged
merged 5 commits into from
Jun 26, 2022

Conversation

ghubstan
Copy link
Owner

Simplify the 'is margin price >= target price' filter for the TakeBestPricedOfferToBuyBtc bot, and related log statements.

Based on PR #6, branch enable-walletpwd-prompt.

ghubstan added 5 commits June 25, 2022 10:25
- When bot is run from a *nix terminal, password input will not be echoed.
- When bot is run from an IDE, it's virtual terminal will echo the input
  (cannot be avoided).

Validate the input during startup, to fail early instead of waiting for
the right offer to take, then failing to unlock the wallet with an
incorrect password.
Copy link
Collaborator

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit b0e36c3 into main Jun 26, 2022
@ghubstan ghubstan deleted the fix-bugs-related-to-margin-config branch June 26, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants