Update the logging documentation #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ReactiveUI logging infrastructure moved to Splat, so all the documentation should go there. Since ReactiveUI defines some useful logging helpers for observables, I've left the documentation of those in there.
Collaborator
|
👍 I'll let this sit and see if anyone else has feels on it |
Owner
|
👍 for cleaning up but 👎 for merge. Agree that the page needs some spring cleaning. Don't agree on this merge because it removes the explanation (however poor it may be) of the following fundamentals:
Completely agree with the notion of funneling users to the documentation and examples at the Splat repo as it will be more up to date/one less thing to maintain. |
Collaborator
|
@ghuntley nice points |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReactiveUI logging infrastructure moved to Splat, so all the
documentation should go there. Since ReactiveUI defines some useful
logging helpers for observables, I've left the documentation of those in
there.