forgot to close the handle

giampaolo · Feb 28, 2015 · f252bd0 · f252bd0
1 parent 29defce
commit f252bd0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/psutil/_psutil_windows.c b/psutil/_psutil_windows.c
@@ -685,6 +685,7 @@ psutil_proc_name(PyObject *self, PyObject *args) {
     pentry.dwSize = sizeof(PROCESSENTRY32);
     ok = Process32First(hSnapShot, &pentry);
     if (! ok) {
+        CloseHandle(hSnapShot);
         PyErr_SetFromWindowsErr(0);
         return NULL;
     }

diff --git a/test/_windows.py b/test/_windows.py
@@ -356,10 +356,10 @@ def compare_with_tolerance(ret1, ret2, tolerance):
                         compare_with_tolerance(ret[3], nt.io_wbytes, tolerance)
                     elif name == 'proc_memory_info':
                         try:
-                            rawtuple = _psutil_windows.proc_memory_info_2(p.pid)
+                            rawtupl = _psutil_windows.proc_memory_info_2(p.pid)
                         except psutil.NoSuchProcess:
                             continue
-                        compare_with_tolerance(ret, rawtuple, tolerance)
+                        compare_with_tolerance(ret, rawtupl, tolerance)
                 except AssertionError:
                     trace = traceback.format_exc()
                     msg = '%s\npid=%s, method=%r, ret_1=%r, ret_2=%r' % (