-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate API types #1039
Labels
Comments
giampaolo
added a commit
that referenced
this issue
Apr 30, 2017
… mainly in terms of returned types and API availability
Windows: https://ci.appveyor.com/project/giampaolo/psutil/build/1152/job/s9d2526hkj6ge7g4
|
giampaolo
added a commit
that referenced
this issue
Apr 30, 2017
Windows:
|
I will handle this in #1040 as a bigger task. Closing this out as duplicate. |
Actually I will handle the |
giampaolo
added a commit
that referenced
this issue
May 13, 2017
OK, this should be fixed by now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From https://github.com/giampaolo/psutil/blob/master/psutil/tests/test_unicode.py:
Basically we assume unicode support is broken on Python 2 and want to make sure unicode is never returned. I added some tests about this (see: 35ebdfb) already.
The only place were we may want to return unicode is
WindowsService.description()
so this serves as a reminder for that (needs investigation).Also, I'm adding tests to make sure the same types (int, float, whatever..., see d67154d, 5aa3af3 and test_contracts.py) are returned across across platforms and I already bumped in a couple of errors on OSX but I expect there will be more.
The text was updated successfully, but these errors were encountered: