[Windows] rewrite of open_files() #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code was messy and had different issues, the main one being there was zero error checking (I suppose in that case we got an empty list). Amongst other things I got rid of global vars (except one), thread events and took inspiration from ProcessHacker source code for the
NtQuerySystemInformationandNtQueryObjectparts which are more robust.Note: the previous version reused the same thread to get the file handle name till the thread hanged (in which case it was terminated) emulating some sort of process pool. This new version serially spawns one thread for each handle on every loop instead. This is a bit slower, but much more sane in terms of code. An alternative to this would be using some sort of IPC method (queue, thread pool) but it's outside of my current expertise.
Finally, this is nicer to (future) Cygwin integration (previous version caused segfault).
Update: related to #340 and #596. Also CC @mrjefftang (original author).