-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite get_open_files #596
Conversation
I closed/re-opened the PR to trigger a new build and it looks like that test case that initially failed is nondeterministic. |
Have you tested this on both Python 2 and 3? Do "make.bat test" and "make.bat test-memleaks" pass? |
Note that I still think the way forward is to go the Sysinternals Handles route and spawn a thread that calls NtQueryObject and waits a for a timeout and kills it off. Looks like we can avoid the associated memory leaks by converting the thread to a fiber. Fixed an issue that looks like it was in the master branch relating to Process.ppid() on Windows. Test failure on Python 3.4 is related to memory leak for net_if_addrs:
Python 2.7:
|
I rewrote get_open_files to clean up a lot of the code and to address the error cases where handles or memory aren't closed/free'd.
This will address #542 since the access mask check is removed.
Hopefully this will address the newest issue in #340 but I don't have a Windows machine with bluetooth to test that. Maybe @jimbo1969 can retest this.