Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NetBSD] available virtual memory is higher than total #2231

Closed
giampaolo opened this issue Apr 13, 2023 · 0 comments · Fixed by #2233
Closed

[NetBSD] available virtual memory is higher than total #2231

giampaolo opened this issue Apr 13, 2023 · 0 comments · Fixed by #2233
Labels
bug critical netbsd

Comments

@giampaolo
Copy link
Owner 

======================================================================
FAIL: psutil.tests.test_system.TestMemoryAPIs.test_virtual_memory
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/psutil/psutil/tests/test_system.py", line 275, in test_virtual_memory
    assert 0 <= mem.percent <= 100, mem
           ^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: svmem(total=1019899904, available=1046573056, percent=-2.6, used=603414528, free=545050624, active=234807296, inactive=133210112, buffers=260288512, cached=368312320, shared=0, wired=294912)

TODO: check how zabbix calculates avail mem: https://github.com/zabbix/zabbix/blob/af5e0f80253e585ca7082ca6bc9cc07400afe2a7/src/libs/zbxsysinfo/netbsd/memory.c
@giampaolo giampaolo mentioned this issue Apr 13, 2023
Merged
giampaolo added a commit that referenced this issue Apr 13, 2023
@giampaolo
[NetBSD] available mem can be higher than total (#2233)
6e2dc77 
On NetBSD "available" memory can be higher than "total". From now now calculate it exactly the same as Zabbix:
https://github.com/zabbix/zabbix/blob/af5e0f80253e585ca7082ca6bc9cc07400afe2a7/src/libs/zbxsysinfo/netbsd/memory.c

Fixes #2231 which produced this failure:

```
======================================================================
FAIL: psutil.tests.test_system.TestMemoryAPIs.test_virtual_memory
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/psutil/psutil/tests/test_system.py", line 275, in test_virtual_memory
    assert 0 <= mem.percent <= 100, mem
           ^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: svmem(total=1019899904, available=1046573056, percent=-2.6, used=603414528, free=545050624, active=234807296, inactive=133210112, buffers=260288512, cached=368312320, shared=0, wired=294912)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug critical netbsd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NetBSD] available mem can be higher than total giampaolo/psutil
1 participant
@giampaolo