Differentiate between partitions and devices using sysfs #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disk_io_counters skips devices that have partitions, and to differentiate partitions from devices we can't use the names - we need to look in sysfs. Partitions and devices have entries in /sys/class/block and only devices have entries in /sys/block This fixes counters of NVMe devices. Also fixed looking up the sector size of partitions.
|
Closed in favor of #1313. |
giampaolo
added a commit
that referenced
this pull request
Jul 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disk_io_counters skips devices that have partitions, and to differentiate partitions from devices we can't use the names - we need to look in sysfs.
Partitions and devices have entries in /sys/class/block and only devices have entries in /sys/block.
This should fix issues #1244 and #1305.
Also fixed looking up the sector size of partitions.