Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add virtual memory compatibility for zfs arc architectures #2385

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hewdoe
Copy link

@hewdoe hewdoe commented Mar 21, 2024

Summary

  • OS: Linux
  • Bug fix: no
  • Type: core
  • Fixes: Adds compatibility for virtual memory calculations on ZFS ARC architestures

Description

On Linux-based OS's, /proc/meminfo does not report memory consumption by the ZFS ARC disks. It's my understanding that this memory is reclaimable.
These changes include what "htop" deems "shrinkable" memory into the used, cached and available memory totals, which solved an issue on one of my systems which was over-reporting memory consumption.

Here are a few resources:
https://www.reddit.com/r/zfs/comments/ha0p7f/understanding_arcstat_and_free/
openzfs/zfs#10255

Please let me know if this is relevant or not and I can add a test and make changes to the readTheDocs Documentation too. Just not necessary at the moment for me if this will only ever be used on my fork

@hewdoe hewdoe marked this pull request as draft March 21, 2024 06:28
@hewdoe hewdoe marked this pull request as ready for review March 22, 2024 02:16
…ce code)

Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>

docs: update HISTORY/CREDITS

Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>

fix: various fixes on account of me not having my linter on:

poor type hinting
incorrect column unpacking of the zfs arc stats file
bad variable naming

Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>

fix: account for shared memory, errant conversion of zfs stats

Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>

refactor: move arc stats call to a separate function to be less obtrusive

Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>
Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>
fix: include zfs arcstats in export list

Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>
Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>
Signed-off-by: Hudson Gerwing <grownuphudson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant