Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comparer.py - added support for schema selection #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rv-solomasov
Copy link

Adding the ability to select which schemas are being compared

Adding the ability to select which schemas are being compared
@colonelpanic8
Copy link

@gianchub I'd like to use this feature. code seems good to me

@gianchub
Copy link
Owner

Hi @rv-solomasov and @colonelpanic8, so sorry I didn't get an email for this PR, but thanks to @colonelpanic8's mention I am now aware of it. The code seems good to me too, but can I ask @rv-solomasov to add tests to make sure the new feature works?
I would add them myself but I have no time at the moment unfortunately.
Thank you

@rv-solomasov
Copy link
Author

rv-solomasov commented Feb 2, 2024

@colonelpanic8 @gianchub Hi! I'm trying to think of an appropriate tests to add here but nothing really comes to mind :)
Apologies as this is my first contribution of a kind and I'm a bit lost with the general practices.
I'm using this particular code with some additional improvements for aligning schemas between mysql and postgres dbs and have not experienced any issues as the added changes are only applied to built-in arguments of various Inspector methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants