Return an error if clusterSelector is not parsable

[bug](projectsveltos/libsveltos#260)

Makefile

@@ -25,7 +25,7 @@ ARCH ?= amd64
 OS ?= $(shell uname -s | tr A-Z a-z)
 K8S_LATEST_VER ?= $(shell curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
 export CONTROLLER_IMG ?= $(REGISTRY)/$(IMAGE_NAME)
-TAG ?= main
+TAG ?= dev
 
 .PHONY: all
 all: build

config/default/manager_image_patch.yaml

@@ -8,5 +8,5 @@ spec:
     spec:
       containers:
       # Change the value of image field below to your controller image URL
-      - image: projectsveltos/access-manager-amd64:main
+      - image: projectsveltos/access-manager-amd64:dev
         name: manager

controllers/rolerequest_controller.go

@@ -467,9 +467,12 @@ func (r *RoleRequestReconciler) getMatchingClusters(ctx context.Context, roleReq
 	logger logr.Logger) ([]corev1.ObjectReference, error) {
 
 	var matchingCluster []corev1.ObjectReference
-	var err error
 	if roleRequestScope.GetSelector() != "" {
-		parsedSelector, _ := labels.Parse(roleRequestScope.GetSelector())
+		parsedSelector, err := labels.Parse(roleRequestScope.GetSelector())
+		if err != nil {
+			logger.V(logs.LogInfo).Info(fmt.Sprintf("failed to parse clusterSelector: %v", err))
+			return nil, err
+		}
 		matchingCluster, err = clusterproxy.GetMatchingClusters(ctx, r.Client, parsedSelector, "", logger)
 		if err != nil {
 			return nil, err

controllers/rolerequest_transformations.go

@@ -130,7 +130,12 @@ func (r *RoleRequestReconciler) requeueRoleRequestForCluster(
 	// matching the Cluster
 	for k := range r.RoleRequests {
 		clusterProfileSelector := r.RoleRequests[k]
-		parsedSelector, _ := labels.Parse(string(clusterProfileSelector))
+		parsedSelector, err := labels.Parse(string(clusterProfileSelector))
+		if err != nil {
+			// When clusterSelector is fixed, this RoleRequest instance will
+			// be reconciled
+			continue
+		}
 		if parsedSelector.Matches(labels.Set(cluster.GetLabels())) {
 			l := logger.WithValues("roleRequest", k.Name)
 			l.V(logs.LogDebug).Info("queuing roleRequest")

manifest/manifest.yaml

@@ -317,7 +317,7 @@ spec:
         - --v=5
         command:
         - /manager
-        image: projectsveltos/access-manager-amd64:main
+        image: projectsveltos/access-manager-amd64:dev
         livenessProbe:
           httpGet:
             path: /healthz