Enable Monitoring and Hubble #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whites11
reviewed
Mar 7, 2023
| @@ -1,4 +1,4 @@ | |||
| {{- if and .Values.operator.enabled .Values.operator.prometheus.enabled .Values.operator.prometheus.serviceMonitor.enabled }} | |||
| {{- if and .Values.operator.enabled .Values.operator.prometheus.enabled }} | |||
There was a problem hiding this comment.
where does this change come from? upstream?
There was a problem hiding this comment.
Not coming from upstream, but something we might have to push for.
- The service needs to be present to be scraped somehow, should not depend on enabling ServiceMonitors. You can see they handle this case for the agent but not for the operator https://github.com/giantswarm/cilium-app/blob/main/helm/cilium/templates/cilium-agent/service.yaml#L26
- We are adding the ServiceMonitors in a different app so this would never be true.
whites11
approved these changes
Mar 7, 2023
fiunchinho
approved these changes
Mar 7, 2023
T-Kukawka
approved these changes
Mar 7, 2023
kopiczko
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Prometheus scraping is not directly enabled in this application as it would make it depend on ServiceMonitor CRD being installed before the CNI.
https://github.com/giantswarm/cilium-servicemonitors-app was created to provide the ServiceMonitors to be scraped by the Observability Bundle's Prometheus agent.
Testing
Description on how cilium can be tested.
Other testing
Description of features to additionally test for cilium installations.
Checklist
values.yamlandvalues.schema.jsonare valid.