Don't automatically upgrade go version with renovate #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stone-z
approved these changes
Sep 6, 2022
Co-authored-by: Zach Stone <zach@giantswarm.io>
kopiczko
approved these changes
Sep 6, 2022
MarcelMue
approved these changes
Sep 7, 2022
|
It seems this doesn't work :( We need to come up with an alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of our operators, the go version was upgraded in
go.modand our CI (which uses go 1.18) stopped working withThere is currently not an easy way to disable go version upgrades in renovate, so one potential solution is to constraint which versions we use. I would add another step to our upgrade guide so that we also upgrade the renovate template constraint.
Checklist