Add pod monitors and remove old service based monitoring #246
Conversation
uvegla
force-pushed
the
add-pod-monitors
branch
from
78c0455 to
24575c8
Compare
| @@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
|
|
|||
There was a problem hiding this comment.
Is there a reason why is false by default ?
There was a problem hiding this comment.
I was not sure, if it is guaranteed that every cluster you install the chart to has pod monitors. If so, I am happy to make it true by default.
There was a problem hiding this comment.
Oh yes we have them on all clusters greater than 18.2
There was a problem hiding this comment.
Well, most of them have pod monitors. It appeared around release 18 IIRC.
So I'd set this value as true by default, with the possibility of disabling for old releases.
But if you want to keep compatibility with old clusters, you may want to keep the service then, rather than completely disabling metrics?
There was a problem hiding this comment.
Workload clusters included? (As customers use the chart as well) Changing to default true then. 👍🏻
There was a problem hiding this comment.
KVM is frozen on an old MCB and therefor Flux release, so probably not an issue for really old ones.
There was a problem hiding this comment.
Yes, WCs > 18.2 have the prometheus-agent running, and support podmons.
uvegla
changed the title
No description provided.