-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy policies as an app #6
Conversation
* Try skipping lint via orb * Trigger CI * Add silly ClusterAnimal policy to test deployment * Bump orb version, remove test policy
@@ -0,0 +1,6 @@ | |||
apiVersion: v1 | |||
name: policies-common |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to prefix everything with policies
? Especially for folders it seems redundant as the repo is already called clusterpolicies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In places where the name is actually used I think it will make more sense. Like with opsctl it would currently be opsctl deploy -i <whatever> policies-kvm
. I tried to keep this similar to the releases
structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that - but the folders in releases
also don't have a prefix. Maybe I am missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The folders for the actual helm charts do https://github.com/giantswarm/releases/tree/master/helm
The outer folders are kustomized
in, which we can't do with ClusterPolicy
CRs because it alphabetizes things and re-quotes strings which break kyverno
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me - sad about kustomize not working :D
Separates policies into
common
,aws
,azure
,kvm
, andvmware
concerns and pushes the charts to the cp test catalog.After https://github.com/giantswarm/opsctl/pull/1109 we can deploy these with
opsctl
.release-operator
behavior is still in progress