Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable vault and cluster-service rules for CAPO and CAPV #314

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Disable vault and cluster-service rules for CAPO and CAPV #314

merged 1 commit into from
Apr 11, 2022

Conversation

erkanerol
Copy link
Contributor

@erkanerol erkanerol commented Apr 11, 2022 •
edited
Loading

Towards giantswarm/roadmap#640

We don't install cluster-service into CAPO and CAPV clusters. We don't have vault machine as well. We deploy vault into MC now. Vault monitoring will be supported soon but we need to disable those now.

Checklist

  • Update changelog in CHANGELOG.md.
  • Request review from oncall area, as well as team (e.g: oncall-kaas-cloud GitHub group).
  • Alerting rules must have a comment documenting why it needs to exist.

@erkanerol erkanerol requested a review from a team as a code owner April 11, 2022 11:11
@erkanerol erkanerol mentioned this pull request Apr 11, 2022
Closed
7 tasks
QuentinBisson
QuentinBisson approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tested

@erkanerol
Copy link
Contributor Author

@QuentinBisson I tested by setting managementCluster.provider.kind to kvm and openstack.

@erkanerol erkanerol merged commit e7a1136 into master Apr 11, 2022
@erkanerol erkanerol deleted the fix-capo-alerts branch April 11, 2022 12:14
@erkanerol
Copy link
Contributor Author

Also tested app 2.12.0-11b25e4b4ac02974f252d35e4c323428c20b4aae from test catalog in gravity

@erkanerol erkanerol mentioned this pull request Apr 12, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBisson QuentinBisson QuentinBisson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erkanerol @QuentinBisson