Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate project to Prettier 3.0.0-alpha.4, run tests against Prettier v1 and v2 #36

Merged
merged 39 commits into from
Nov 5, 2022

Conversation

kachkaev
Copy link
Member

@kachkaev kachkaev commented Nov 5, 2022

Closes #30

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 94.68% // Head: 95.28% // Increases project coverage by +0.60% 🎉

Coverage data is based on head (705d3b4) compared to base (0780588).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   94.68%   95.28%   +0.60%     
==========================================
  Files           5        6       +1     
  Lines          94      106      +12     
  Branches       14       16       +2     
==========================================
+ Hits           89      101      +12     
  Misses          4        4              
  Partials        1        1              
Impacted Files Coverage Δ
src/parser.ts 88.88% <100.00%> (+0.65%) ⬆️
src/test-helpers/prettier-wrapper.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kachkaev kachkaev changed the title Test plugin against Prettier v3 Support Prettier v3 Nov 5, 2022
@kachkaev kachkaev changed the title Support Prettier v3 Check Prettier v3 and v1 compatibility Nov 5, 2022
@kachkaev kachkaev changed the title Check Prettier v3 and v1 compatibility Migrate project to Prettier v3, run tests against v1 and v2 Nov 5, 2022
@kachkaev kachkaev changed the title Migrate project to Prettier v3, run tests against v1 and v2 Migrate project to Prettier 3.0.0-alpha.4, run tests against Prettier v1 and v2 Nov 5, 2022
@kachkaev kachkaev merged commit 49983c5 into main Nov 5, 2022
@kachkaev kachkaev deleted the ak/test-against-v3 branch November 5, 2022 23:11
@fisker
Copy link

fisker commented Nov 5, 2022

@kachkaev
Copy link
Member Author

kachkaev commented Nov 5, 2022

👋 @fisker! I was thinking of doing something like that in CI, but then decided to include three local Prettier versions. This way I can switch between them on the fly while keeping git status clean. I might switch to yarn upgrade in CI at some point, but I don’t see any problems with the current approach at the moment.

Thanks for taking a look at this PR, let me know if you have any other thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Prettier v3
2 participants