Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path to zlib root should not be hard-coded #27

Open
dzhoshkun opened this issue Mar 15, 2019 · 1 comment
Open

Path to zlib root should not be hard-coded #27

dzhoshkun opened this issue Mar 15, 2019 · 1 comment

Comments

@dzhoshkun
Copy link
Contributor

dzhoshkun commented Mar 15, 2019 •
edited
Loading

For testing purposes, ZLIB_ROOT can be defined as an envvar in CI script. However that still doesn't solve the problem of distributing code.
dzhoshkun added a commit that referenced this issue Mar 15, 2019
@dzhoshkun
Issue #23: hard-coding zlib root #27 in CMake file
052a3ed
dzhoshkun added a commit that referenced this issue Mar 15, 2019
@dzhoshkun
Issue #23, #27: fixed backslashes
7c65875
dzhoshkun added a commit that referenced this issue Mar 20, 2019
@dzhoshkun
Issue #23: hard-coding zlib root #27 in CMake file
f51fbcd
dzhoshkun added a commit that referenced this issue Mar 20, 2019
@dzhoshkun
Issue #23, #27: fixed backslashes
0daddee
dzhoshkun added a commit that referenced this issue Mar 20, 2019
@dzhoshkun
Issue #23: hard-coding zlib root #27 in CMake file
9cf9b2e
dzhoshkun added a commit that referenced this issue Mar 20, 2019
@dzhoshkun
Issue #23, #27: fixed backslashes
9ca29c3
@dzhoshkun dzhoshkun mentioned this issue Mar 21, 2019
Open
5 tasks
@dzhoshkun
Copy link
Contributor Author

Related to #26

dzhoshkun added a commit that referenced this issue Mar 21, 2019
@dzhoshkun
Merge pull request #26 from gift-surg/23-support-for-epiphan-dvi2pcie…
01786c7 
…-duo

Added support for Epiphan DVI2PCIe Duo (subject to #27 #33 #34)
dzhoshkun added a commit that referenced this issue Apr 8, 2019
@dzhoshkun
Issue #27: removed hard-coded ZLIB_ROOT from CMake discovery script
40894f7
dzhoshkun added a commit that referenced this issue Apr 8, 2019
@dzhoshkun
Issue #27: added a zlib_root var to CI script
3f16802
dzhoshkun added a commit that referenced this issue Apr 8, 2019
@dzhoshkun
Issue #27: using uppercase var name for zlib root
f2ae35c
dzhoshkun added a commit that referenced this issue Apr 8, 2019
@dzhoshkun
Revert "Issue #27: using uppercase var name for zlib root"
9201a47 
This reverts commit f2ae35c.
dzhoshkun added a commit that referenced this issue Apr 8, 2019
@dzhoshkun
Issue #27: explicitly passing ZLIB_ROOT to cmake configuration call
0e3d2d9
dzhoshkun added a commit that referenced this issue Apr 8, 2019
@dzhoshkun
Issue #27: using double quotes when passing envvar to cmake config
5fa37c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dzhoshkun