Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle accessibility alerts on help page #2152

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

luistoptal
Copy link
Collaborator

@luistoptal luistoptal commented Dec 31, 2024

Pull request for issue: #1330

Review a11y issues in http://gigadb.gigasciencejournal.com/site/help and fix them whenever possible

How to test?

Navigate to http://gigadb.gigasciencejournal.com/site/help, run WAVE audit https://wave.webaim.org/ and check that issues have been handled in some way

How have functionalities been implemented?

  • I removed all links to the GigaDB website as we are already in that website and so they don't make sense
  • I removed the linked urls in the curl commands as these are just examples of curl requests and the user should not follow those links
  • I extended the screen reader only text on the links to xsl and pdf files
  • Tweaked the footer so that the color contrast issue no longer appears in the WAVE audit (it didn't matter from a UX prespective, but removing the false positive on the common footer improves the DX)
  • Tweaked footer links so that they have hover effect

Any issues with implementation?

See #1330 (comment) for details on the challenges on optimizing a11y for this page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tasks To Do
Development

Successfully merging this pull request may close these issues.

1 participant