Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility errors on dataset page #2153

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

luistoptal
Copy link
Collaborator

@luistoptal luistoptal commented Dec 31, 2024

Pull request for issue: #1329

Minimize a11y issues in dataset page, eg. http://gigadb.gigasciencejournal.com/dataset/100006

How to test?

Run WAVE audit in any dataset page and confirm there are no errors

As for the "alerts" they are caused by duplicate file links in the files table which we opted to leave untouched, because it is not clear to us whether this is a requested feature or not

How have functionalities been implemented?

  • Override background color of bootstrap stripe table to use one of the colors defined in our styles, also override text color on such context to make sure it is accessible
  • Override color of + / - button to make it accessible
  • Update color styles of sr-only text to minimize accessibility errors, these errors do not affect the UX but are annoying when running a11y audits

Any issues with implementation?

--

Any changes to automated tests?

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tasks To Do
Development

Successfully merging this pull request may close these issues.

1 participant