Fixes filename column width in dataset page

[luistoptal]

Pull request for issue: #1119

This PR should fix the issue with very long filenames in the dataset files table

How to test?

• navigate to http://gigadb.gigasciencejournal.com/dataset/100006
• in the files table, alter the html to add a very long filename
• the filename should wrap when exceeding the cell width

How have functionalities been implemented?

• fixed the filename column width to 20ch

Any issues with implementation?

--

Any changes to automated tests?

--

[kencho51]

Hi @luistoptal,

question Shouldn't we suppose to fix that if the file name is longer then 100, the whole file name can still be showed? As even I checked out the develop branch, and the text is actually already wrapped:

suggestion: Is it possible to make the column width can be dragged by user manually?
issue: The acceptance criteria is to allow name is longer than 100 characters, the File_name field is still hardcoded as max 100, no more text would be allowed if longer than 100, you can test at http://gigadb.gigasciencejournal.com/adminFile/update/id/17680
suggestion: Remove this required option, so there will be no limit on the file name's length.

[luistoptal]

the text is actually already wrapped

If the filename is one single word without breaks then the text was not wrapped

Is it possible to make the column width can be dragged by user manually?

It is possible to make the columns resizeable with javascript. I believe very long file names is rather a fringe use case. I am not sure allowing users to change column width is an effective solution. I believe wrappign might be enough. However we can make column width draggable. Can you confirm we want this behavior? The ticket does mention either wrapping or allowing draggable column width. I think if the goal is for the user to be able to read the complete file name, wrapping is better because it does not require user interaction. Also the user might click on the header and sort the column instead by mistake if they try to drag

As for the 100 char length. I assumed the issue is that despite the limitation to 100 length, still some files were longer than that and the UI should not assume all files will be capped at 100 chars

Do we actually want to enable filenames longer than 100 chars?

[only1chunts]

I'm have created another ticket (#2170) for the not allowing >100char feature (as suggested in the addfitional infor in #1119 )so for this ticket we can focus on the display. I like the fixed column width with filename wrapping for the reasons Luis outlines.

[kencho51]

Hi @luistoptal,

Given all my questions have been addressed, will be happy to approve after the merge conflicts have been fixed