Support Xcode 15.3 and Swift 5.10 #113
Merged
+298
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddi-kit
reviewed
Jan 29, 2024
Comment on lines
+29
to
+31
| if [[ -n "${{ env.TOOLCHAINS }}" ]]; then | ||
| xcrun --toolchain ${{ env.TOOLCHAINS }} swift test --verbose | ||
| else |
There was a problem hiding this comment.
Please note why this workaround is necessary by comments
Comment on lines
+17
to
+24
| typealias ScipioAbsolutePath = TSCBasic.AbsolutePath | ||
| typealias SwiftPMAbsolutePath = Basics.AbsolutePath | ||
|
|
||
| #else | ||
|
|
||
| // Below Swift 5.9, Basics.AbsolutePath is not implemented yet. So this is required to keep backward-compatibility | ||
|
|
||
| typealias ScipioAbsolutePath = TSCBasic.AbsolutePath |
There was a problem hiding this comment.
Can you move it to out side of #if block? like below. And please add comment to actual place where we need to typealias
typealias ScipioAbsolutePath = TSCBasic.AbsolutePath
#if swift(>=5.10)
// Above Swift 5.10, SwiftPM requires their own AbsolutePath,
// so we have to bridge them to Scipio requires by typealias
typealias SwiftPMAbsolutePath = Basics.AbsolutePath
#else
...There was a problem hiding this comment.
It's easy to understand to define this in both paths
Co-authored-by: freddi(Yuki Aki) <freddi-kit@users.noreply.github.com>
freddi-kit
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Xcode 15.3 beta 1