Drop 5.8 support and update SwiftLint violations

.github/workflows/tests.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         xcode_version: ["15.3"]
-        swift: ["5.8.1", "5.9.2", "5.10.0"]
+        swift: ["5.9.2", "5.10.0"]
     env: 
       DEVELOPER_DIR: "/Applications/Xcode_${{ matrix.xcode_version }}.app/Contents/Developer"
     runs-on: macos-14

README.md

@@ -3,10 +3,8 @@
 ![GitHub Workflow Status (with event)](https://img.shields.io/github/actions/workflow/status/giginet/Scipio/tests.yml?style=flat-square&logo=github)
 ![Swift 5.10](https://img.shields.io/badge/Swift-5.10-FA7343?logo=swift&style=flat-square)
 ![Swift 5.9](https://img.shields.io/badge/Swift-5.9-FA7343?logo=swift&style=flat-square)
-![Swift 5.8](https://img.shields.io/badge/Swift-5.8-FA7343?logo=swift&style=flat-square)
 [![Xcode 15.3](https://img.shields.io/badge/Xcode-15.3-147EFB?style=flat-square&logo=xcode&link=https%3A%2F%2Fdeveloper.apple.com%2Fxcode%2F)](https://developer.apple.com/xcode/)
 [![Xcode 15.2](https://img.shields.io/badge/Xcode-15.2-147EFB?style=flat-square&logo=xcode&link=https%3A%2F%2Fdeveloper.apple.com%2Fxcode%2F)](https://developer.apple.com/xcode/)
-[![Xcode 14.3](https://img.shields.io/badge/Xcode-14.3-147EFB?style=flat-square&logo=xcode&link=https%3A%2F%2Fdeveloper.apple.com%2Fxcode%2F)](https://developer.apple.com/xcode/)
 [![SwiftPM](https://img.shields.io/badge/SwiftPM-compatible-green?logo=swift&style=flat-square)](https://swift.org/package-manager/) 
 [![Documentation](https://img.shields.io/badge/Documentation-available-green?style=flat-square)](https://giginet.github.io/Scipio/documentation/scipio/)
 ![Platforms](https://img.shields.io/badge/Platform-iOS%7CmacOS%7CwatchOS%7CtvOS%7CvisionOS-lightgray?logo=apple&style=flat-square)
@@ -136,15 +134,12 @@ See [Convert Single Swift Package to XCFramework](https://giginet.github.io/Scip
 
 ## Supported Xcode and Swift version
 
-Currently, we support Swift 5.8, 5.9, and 5.10.
-
-Swift 5.8 support will be dropped in the future.
+Currently, we support Swift 5.9, and 5.10.
 
 |    | Xcode      | Swift |
 |----|------------|-------|
 | ✅ | 15.3       | 5.10  |
 | ✅ | 15.0<=15.2 | 5.9   |
-| ✅ | 14.3       | 5.8   |
 
 ## Reliability
 

Sources/ScipioKit/Executor.swift

@@ -145,7 +145,7 @@ extension ExecutorResult {
     func unwrapOutput() throws -> String {
         switch output {
         case .success(let data):
-            return String(data: Data(data), encoding: .utf8)!
+            return String(decoding: Data(data), as: UTF8.self)
         case .failure(let error):
             throw error
         }
@@ -154,7 +154,7 @@ extension ExecutorResult {
     func unwrapStdErrOutput() throws -> String {
         switch stderrOutput {
         case .success(let data):
-            return String(data: Data(data), encoding: .utf8)!
+            return String(decoding: Data(data), as: UTF8.self)
         case .failure(let error):
             throw error
         }

Sources/ScipioKit/Producer/PIF/BuildParametersGenerator.swift

@@ -40,8 +40,6 @@ struct BuildParametersGenerator {
         let targetArchitecture = buildParameters.targetTriple.arch?.rawValue ?? "arm64"
         #elseif swift(>=5.9)
         let targetArchitecture = buildParameters.triple.arch?.rawValue ?? "arm64"
-        #else
-        let targetArchitecture = buildParameters.triple.arch.rawValue
         #endif
 
         // Generate the run destination parameters.

Sources/ScipioKit/Producer/PIF/PIFCompiler.swift

@@ -124,7 +124,7 @@ struct PIFCompiler: Compiler {
             isXcodeBuildSystemEnabled: true,
             driverParameters: BuildParameters.Driver(enableParseableModuleInterfaces: buildOptions.enableLibraryEvolution)
         )
-        #elseif swift(>=5.9)
+        #else
         try .init(
             dataPath: descriptionPackage.buildDirectory.spmAbsolutePath,
             configuration: buildOptions.buildConfiguration.spmConfiguration,
@@ -134,16 +134,6 @@ struct PIFCompiler: Compiler {
             enableParseableModuleInterfaces: buildOptions.enableLibraryEvolution,
             isXcodeBuildSystemEnabled: true
         )
-        #else
-        .init(
-            dataPath: descriptionPackage.buildDirectory,
-            configuration: buildOptions.buildConfiguration.spmConfiguration,
-            toolchain: toolchain,
-            destinationTriple: toolchain.triple,
-            flags: .init(),
-            enableParseableModuleInterfaces: buildOptions.enableLibraryEvolution,
-            isXcodeBuildSystemEnabled: true
-        )
         #endif
     }
 }

Sources/ScipioKit/Producer/PIF/ToolchainGenerator.swift

@@ -2,9 +2,7 @@ import Foundation
 import TSCUtility
 import PackageModel
 import TSCBasic
-#if swift(>=5.9)
 import struct Basics.Triple
-#endif
 
 struct ToolchainGenerator {
     private let toolchainDirPath: AbsolutePath

Tests/ScipioKitTests/CacheSystemTests.swift

@@ -36,7 +36,7 @@ InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault
         let encoder = JSONEncoder()
         encoder.outputFormatting = [.sortedKeys, .prettyPrinted]
         let data = try encoder.encode(cacheKey)
-        let rawString = try XCTUnwrap(String(data: data, encoding: .utf8))
+        let rawString = try XCTUnwrap(String(decoding: data, as: UTF8.self))
         let expected = """
 {
   "buildOptions" : {

Tests/ScipioKitTests/RunnerTests.swift

@@ -34,7 +34,7 @@ final class RunnerTests: XCTestCase {
 
     private let plistDecoder: PropertyListDecoder = .init()
 
-    override class func setUp() {
+    override static func setUp() {
         LoggingSystem.bootstrap { _ in SwiftLogNoOpLogHandler() }
 
         super.setUp()
@@ -136,7 +136,7 @@ final class RunnerTests: XCTestCase {
                 fileManager.fileExists(atPath: moduleMapPath),
                 "Should exist a modulemap"
             )
-            let moduleMapContents = try XCTUnwrap(fileManager.contents(atPath: moduleMapPath).flatMap { String(data: $0, encoding: .utf8) })
+            let moduleMapContents = try XCTUnwrap(fileManager.contents(atPath: moduleMapPath).flatMap { String(decoding: $0, as: UTF8.self) })
             XCTAssertEqual(
                 moduleMapContents,
                 """
@@ -186,7 +186,7 @@ final class RunnerTests: XCTestCase {
                 fileManager.fileExists(atPath: moduleMapPath),
                 "Should exist a modulemap"
             )
-            let moduleMapContents = try XCTUnwrap(fileManager.contents(atPath: moduleMapPath).flatMap { String(data: $0, encoding: .utf8) })
+            let moduleMapContents = try XCTUnwrap(fileManager.contents(atPath: moduleMapPath).flatMap { String(decoding: $0, as: UTF8.self) })
             XCTAssertEqual(
                 moduleMapContents,
                 """
@@ -630,7 +630,7 @@ final class RunnerTests: XCTestCase {
         XCTAssertTrue(fileManager.fileExists(atPath: moduleMapPath.path))
 
         let generatedModuleMapData = try XCTUnwrap(fileManager.contents(atPath: moduleMapPath.path))
-        let generatedModuleMapContents = String(data: generatedModuleMapData, encoding: .utf8)
+        let generatedModuleMapContents = String(decoding: generatedModuleMapData, as: UTF8.self)
 
         let expectedModuleMap = """
 framework module MyTarget {