Improve DescriptionPackage.resolveBuildProducts() performance
#134
+64
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I will implement Swift 6 support on this branch after #133 is merged. |
|
I merged #133. Could you fix this PR for Xcode 15.4 and Xcode 16? |
Ryu0118
force-pushed
the
improve-resolve-build-products-performance
branch
from
8e28a73 to
999ef2e
Compare
Ryu0118
force-pushed
the
improve-resolve-build-products-performance
branch
from
999ef2e to
1bb3d13
Compare
|
@giginet OK, I have fixed it. Could you review these changes again? |
freddi-kit
reviewed
Jul 10, 2024
There was a problem hiding this comment.
implementation is reasonable for me 👍
@Ryu0118 Could you show me the result of this refactoring? How times it speed up?
|
@freddi-kit I tested the execution of |
|
Sorry, the current main seems to be broken. I fixed this on #135. Please moment. |
Ryu0118
force-pushed
the
improve-resolve-build-products-performance
branch
from
b378923 to
6219b25
Compare
Ryu0118
force-pushed
the
improve-resolve-build-products-performance
branch
from
6219b25 to
03a4e7c
Compare
giginet
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In my personal application, the package contains a large number of targets, which causes the
resolveBuildProducts()function to take a significant amount of time to execute. The common libraries added as dependencies to multiple targets lead to redundant generation of the same BuildProducts, resulting in overhead.Proposed Solution
To address this issue, I created a
BuildProductsResolverclass. This class caches the targets passed to thebuildProducts(from:)function in a visitedTargets property. By doing this, when the same target is encountered again, it returns early, preventing redundant processing. This change significantly reduces execution time by eliminating repeated operations.