Add x86_64 binary to an artifact bundle in a release #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, a new rule, |
giginet
reviewed
Sep 14, 2024
There was a problem hiding this comment.
I didn't know the update! It may be introduced since SwiftPM 6.0.
On CI, we are still using Xcode 15.4. It may use Package@swift-5.10. This job was only executed on PR was merged into the main so x86_64 support will not be worked well.
DEVELOPER_DIR: "/Applications/Xcode_15.4.app/Contents/Developer"
Could you update DEVELOPER_DIR to Xcode 16?
|
Actually, this is not Swift 6 feature! |
giginet
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we can add x86_64 binary to an artifact bundle by build the project twice.
When scipio is built for arm64, the binary is generated at
./.build/arm64-apple-macosx/release/scipio.And when it is built for x86_64, the binary is generated at
./.build/x86_64-apple-macosx/release/scipio.ArtifactBundleGen used by scipio can combines both binaries into an artifact bundle when they exist.
This is the artifact bundle that I made in my forked repository.
https://github.com/mtj0928/Scipio/releases/download/0.21.0/scipio.artifactbundle.zip