Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Swift 5 support #150

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Drop Swift 5 support #150

merged 4 commits into from
Oct 22, 2024

Conversation

giginet
Copy link
Owner

@giginet giginet commented Oct 17, 2024

This PR drops Swift 5 support.

Since this, we have to use Xcode 16 to develop, but it can be used by Swift 5 code.

Copy link
Collaborator

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧹

Comment on lines 71 to 65
#if compiler(<6.0)

// Backward compatibility below 6.0 compiler
// Convert Foundation.URL to Path
extension Command {
fileprivate static func prebuildCommand(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not removed?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. My change was wrong

@giginet giginet merged commit 3d8f3bc into main Oct 22, 2024
2 checks passed
@giginet giginet deleted the drop-5-support branch October 22, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants