Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commutative_prod_iff #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

commutative_prod_iff #5

wants to merge 1 commit into from

Conversation

Elisiah
Copy link
Collaborator

@Elisiah Elisiah commented Nov 30, 2021

No description provided.

gihanmarasingha
gihanmarasingha requested changes Dec 26, 2021
View reviewed changes
Copy link
Owner

@gihanmarasingha gihanmarasingha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style suggestions:

Don't have a brace on a line by itself. For example, have

  { rw [is_comm, is_comm, is_comm],

rather than

  {
    rw [is_comm, is_comm, is_comm],
```

gihanmarasingha
gihanmarasingha reviewed Dec 26, 2021
View reviewed changes
src/groupTheory/basic.lean
},
},
{
rintro ⟨p₁, p₂⟩,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combine the rintro and intros lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gihanmarasingha gihanmarasingha gihanmarasingha requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elisiah @gihanmarasingha