Merge pull request #166 from llllvvuu/fix/build_arg_first

fix: error TS6369: Option '--build' must be the first command line argument.
gilamran · Mar 27, 2024 · de62974 · de62974
2 parents 108d6ed + f683e93
commit de62974
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/src/lib/args-manager.ts b/src/lib/args-manager.ts
@@ -62,6 +62,14 @@ export function extractArgs(inputArgs: string[]) {
   } else {
     compiler = require.resolve(compiler, { paths: [process.cwd()] });
   }
+  if (signalEmittedFiles || requestedToListEmittedFiles) {
+    if (args[0] === '--build' || args[0] === '-b') {
+      // TS6369: Option '--build' must be the first command line argument.
+      args.splice(1, 0, '--listEmittedFiles');
+    } else {
+      args.unshift('--listEmittedFiles');
+    }
+  }
 
   return {
     onFirstSuccessCommand,

diff --git a/src/lib/tsc-watch.ts b/src/lib/tsc-watch.ts
@@ -125,7 +125,6 @@ function spawnTsc({ maxNodeMem, requestedToListEmittedFiles, signalEmittedFiles
   const nodeArgs = [
     ...((maxNodeMem) ? [`--max_old_space_size=${maxNodeMem}`] : []),
     tscBin,
-    ...((signalEmittedFiles || requestedToListEmittedFiles) ? ['--listEmittedFiles'] : []),
     ...args
   ];
 

diff --git a/src/test/args-manager.test.ts b/src/test/args-manager.test.ts
@@ -43,6 +43,19 @@ describe('Args Manager', () => {
     expect(args.indexOf('--watch')).toBe(3);
   });
 
+  it('Should not insert args before --build (TS6369)', () => {
+    const { args } = extractArgs([
+      'node',
+      'tsc-watch.js',
+      '--signalEmittedFiles',
+      '--build',
+      '1.tsconfig.conf',
+      '2.tsconfig.conf',
+    ]);
+    expect(args.indexOf('--build')).toBe(0);
+    expect(args.indexOf('--listEmittedFiles')).toBe(1);
+  })
+
   it('Should not re-add watch', () => {
     expect(
       extractArgs(['node', 'tsc-watch.js', '-w', '1.ts']).args.indexOf('-w'),
@@ -118,11 +131,13 @@ describe('Args Manager', () => {
   it('Should return the signalEmittedFiles', () => {
     expect(extractArgs(['node', 'tsc-watch.js', '1.ts']).signalEmittedFiles).toBe(false);
     expect(extractArgs(['node', 'tsc-watch.js', '--signalEmittedFiles', '1.ts']).signalEmittedFiles).toBe(true);
+    expect(extractArgs(['node', 'tsc-watch.js', '--signalEmittedFiles', '1.ts']).args.includes('--listEmittedFiles')).toBe(true);
   });
 
   it('Should return requestedToListEmittedFiles when tsc native listEmittedFiles is set', () => {
     expect(extractArgs(['node', 'tsc-watch.js', '1.ts']).requestedToListEmittedFiles).toBe(false);
     expect(extractArgs(['node', 'tsc-watch.js', '--listEmittedFiles', '1.ts']).requestedToListEmittedFiles).toBe(true);
+    expect(extractArgs(['node', 'tsc-watch.js', '--listEmittedFiles', '1.ts']).args.includes('--listEmittedFiles')).toBe(true);
   });
 
   it('Should return the compiler', () => {