Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Commit

Permalink
REALLY make the container python 3.12
Browse files Browse the repository at this point in the history
  • Loading branch information
gilesknap committed Jan 6, 2024
1 parent fc467ad commit 27f2e66
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
8 changes: 1 addition & 7 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# container. The devcontainer should be rootful and use podman or docker
# with user namespaces.

ARG BASE="mcr.microsoft.com/vscode/devcontainers/python:0-3.10-bullseye"
ARG BASE="mcr.microsoft.com/devcontainers/python:dev-3.12-bullseye"
FROM ${BASE} as base

# use root to pin where the packages will install
Expand All @@ -13,12 +13,6 @@ ENV PATH=/root/.local/bin:$PATH

FROM base as developer

ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && \
apt-get install -y --no-install-recommends \
gcc python3-dev && \
rm -rf /var/lib/apt/lists/*

WORKDIR /workspace
COPY . .

Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/local_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ echo building $container_name ...
# run the build with required build-args for a runtime build
cd ${THIS_DIR}
ln -s ../dist .
docker build --build-arg BASE=python:3.10-slim -t $container_name .. --file ./Dockerfile
docker build --build-arg BASE=python:3.12-slim -t $container_name .. --file ./Dockerfile
unlink dist
2 changes: 1 addition & 1 deletion .github/workflows/code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ jobs:
context: .
platforms: linux/amd64,linux/arm/v7,linux/arm64/v8
push: true
build-args: BASE=python:3.10-slim
build-args: BASE=python:3.12-slim
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
cache-from: type=local,src=/tmp/.buildx-cache
Expand Down

0 comments on commit 27f2e66

Please sign in to comment.