This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Protect BadIds.py from an empty bad ids file. #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the bad ids file is empty (which could happen if the process is interrupted at an inopportune moment, then when the process next starts and attempts to read the file, there will be a crash due to accessing the length of a NoneType. safe_load returns None when the content of the file is empty.
|
Thanks for this. I'll make a release. |
truecharts-admin
referenced
this pull request
in truecharts/public
May 18, 2024
… v3.2.2@38ecd16 by renovate (#22221) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gilesknap/gphotos-sync](https://togithub.com/gilesknap/gphotos-sync) | patch | `3.2.1` -> `3.2.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gilesknap/gphotos-sync (ghcr.io/gilesknap/gphotos-sync)</summary> ### [`v3.2.2`](https://togithub.com/gilesknap/gphotos-sync/releases/tag/3.2.2) [Compare Source](https://togithub.com/gilesknap/gphotos-sync/compare/3.2.1...3.2.2) *** #### What's Changed - tutorial: fix github url by [@​sebrem](https://togithub.com/sebrem) in [https://github.com/gilesknap/gphotos-sync/pull/476](https://togithub.com/gilesknap/gphotos-sync/pull/476) - Protect BadIds.py from an empty bad ids file. by [@​peterjdolan](https://togithub.com/peterjdolan) in [https://github.com/gilesknap/gphotos-sync/pull/481](https://togithub.com/gilesknap/gphotos-sync/pull/481) - drop rope folder by [@​gilesknap](https://togithub.com/gilesknap) in [https://github.com/gilesknap/gphotos-sync/pull/482](https://togithub.com/gilesknap/gphotos-sync/pull/482) #### New Contributors - [@​sebrem](https://togithub.com/sebrem) made their first contribution in [https://github.com/gilesknap/gphotos-sync/pull/476](https://togithub.com/gilesknap/gphotos-sync/pull/476) - [@​peterjdolan](https://togithub.com/peterjdolan) made their first contribution in [https://github.com/gilesknap/gphotos-sync/pull/481](https://togithub.com/gilesknap/gphotos-sync/pull/481) **Full Changelog**: gilesknap/gphotos-sync@3.2.1...3.2.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguNiIsInVwZGF0ZWRJblZlciI6IjM3LjM2OC42IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the bad ids file is empty (which could happen if the process is interrupted at an inopportune moment, then when the process next starts and attempts to read the file, there will be a crash due to accessing the length of a NoneType. safe_load returns None when the content of the file is empty.