This repository has been archived by the owner on Dec 21, 2020. It is now read-only.
Report errors upstream instead of panicking. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplicating the code a lot. In particular, it makes it difficult to report errors. Removed panic() calls. Instead report errors upstream.
dependency between classes.
This is a prep to code-share dicom and netdicom better.
Started removing the Parser class. It's empty.
Remove the pipe code. It's not all that useful. The image-dumping code is subsumed by dicomutil.
Attrs aren't used.
Handle undefined-length sequence properly.
…tax. Defined constants for well-known UID types, such as "Transfer Syntax" and "SOP Class".
…ck to make CSTORE working.
TODO: handle the metadata tags more properly.
Add convenience functions for specifying encoding using the transfersyntaxuid.
…o more natural code.
…h the DICOM standard's. The new code allows encoding as long as the golang representation matches.
|
As someone who uses this library, the suggested change sounds great - as you might imagine, I have not reviewed the code yet as it looks like a rather large diff 🙂 Have you considered renaming your fork of the library and keeping it that way? I don't know if @gillesdemey is around anymore, but these changes seem extensive enough to nearly be a new codebase. |
|
I'm still around and keeping my eye on this PR! :) In all honesty, I'm considering deprecating this library since I no longer have time to maintain it and advise users to check out @yasushi-saito 's fork unless some folks are willing to step forward and help out. |
added 7 commits
October 9, 2017 21:49
In particular, an empty query condition for VR of "LT", "OW", etc, was not considered empty.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a collateral change, remove uses of channels. It doesn't improve performance. Uses of channels make error reporting difficult.