Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abstract LuaObject superclass for all Lua objects #32

Merged
merged 16 commits into from
Oct 10, 2023
Merged

Add abstract LuaObject superclass for all Lua objects #32

merged 16 commits into from
Oct 10, 2023

Conversation

gilzoide
Copy link
Owner

@gilzoide gilzoide commented Oct 9, 2023 •
edited
Loading

  • This simplifies common code between Lua object classes and makes it possible for all of them to be abstract
  • LuaState does not inherit from LuaTable anymore, use the globals property to access the Lua global table
  • LuaObjects now have a Ref to the corresponding LuaState, which avoids problems of objects being used after the Lua state is destroyed

gilzoide added 16 commits October 9, 2023 08:24
@gilzoide
Add "globals" and "registry" property getters for LuaState
ca84a32
@gilzoide
Make LuaState inherit from RefCounted instead of LuaTable
34ddd5d
@gilzoide
Make LuaTable and LuaUserdata abstract
fa79c59 
This way they cannot be instantiated by GDScript directly without a valid Lua object.
@gilzoide
Replace LuaTable.geti/seti for get_value/set_value
eb9d11e
@gilzoide
Add to_variant(lua_State *, int) overload
86620cf
@gilzoide
Add tests for get_value and set_value
803b86d
@gilzoide
Add LuaObject class for unwrapping them when pushing Variants to Lua
54da196
@gilzoide
Make LuaTable inherit LuaObject
30c79f1
@gilzoide
Make LuaLightUserdata inherit LuaObject
c15f311
@gilzoide
Make LuaFunction inherit LuaObject
a696a70
@gilzoide
Make LuaCoroutine inherit LuaObject
8fb1b3b
@gilzoide
Add get/set as aliases for get_value/set_value
54053a8
@gilzoide
Refactor LuaObject with generic subclass, retaining a Ref<LuaState>
0e00f67 
This simplifies common code between LuaObject subclasses and makes sure that they are not destroyed after the corresponding LuaState.
@gilzoide
Add unit test for LuaObject lifetime when LuaState is gone
6697399
@gilzoide
Remove LuaCoroutine destructor
0d28c7d 
We cannot be sure that it's safe to close the thread, since it might still be referenced and used in Lua
@gilzoide
Rename LuaObject::to_pointer -> get_pointer_value
fcf8742
@gilzoide gilzoide merged commit 02e7e08 into main Oct 10, 2023
@gilzoide gilzoide deleted the abstract-table branch October 10, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gilzoide