Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs uncovered by AFL #41

Merged
merged 3 commits into from
Feb 3, 2017
Merged

Fix bugs uncovered by AFL #41

merged 3 commits into from
Feb 3, 2017

Commits on Feb 3, 2017

  1. Generate sanity tests from the AFL seed test cases

    @fitzgen
    fitzgen committed Feb 3, 2017
    Configuration menu
    Copy the full SHA
    6d3eaba View commit details
    Browse the repository at this point in the history

  2. Handle potential overflows in parse_number 

    This fixes an issue discovered by AFL.rs, where we eagerly unwrap the result of
`isize::from_str_radix` because we checked that the string contains only valid
digits. However, we did not check that the string of digits form a number within
the range of `isize`, and potentially try to parse a number larger than
`isize::MAX`. This resulted in an `Err` return value, and a panic when we unwrap
it.
    @fitzgen
    fitzgen committed Feb 3, 2017
    Configuration menu
    Copy the full SHA
    527cd52 View commit details
    Browse the repository at this point in the history

  3. Add the AFL hanging test cases as well

    @fitzgen
    fitzgen committed Feb 3, 2017
    Configuration menu
    Copy the full SHA
    9ba5c2d View commit details
    Browse the repository at this point in the history