Cleanup for pubnames/pubtypes/aranges #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids needing to use hacks for the docs, and ensures the docs stay consistent. It also makes error messages involving these types simpler, since they now show the type the user thinks they are using, instead of the large DebugLookup alias.
Before: test bench_parsing_debug_aranges ... bench: 33,146 ns/iter (+/- 2,739) test bench_parsing_debug_pubnames ... bench: 77,700 ns/iter (+/- 1,518) test bench_parsing_debug_pubtypes ... bench: 39,810 ns/iter (+/- 2,894) After: test bench_parsing_debug_aranges ... bench: 29,536 ns/iter (+/- 2,591) test bench_parsing_debug_pubnames ... bench: 62,172 ns/iter (+/- 4,016) test bench_parsing_debug_pubtypes ... bench: 24,364 ns/iter (+/- 495)
They use the same parsing code, so they must be the same.
fitzgen
approved these changes
Jul 11, 2017
src/lookup.rs
Outdated
|
|
||
| fn parse_offset(input: &mut R, format: Format) -> Result<Self::Offset>; | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| pub struct PubStuffHeader { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.