Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement indexed values for DWARF 5 #358

Merged
merged 12 commits into from
Jan 15, 2019
Merged

Implement indexed values for DWARF 5 #358

merged 12 commits into from
Jan 15, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Jan 14, 2019

This covers:

  • addresses in .debug_addr
  • string offsets in .debug_str_offsets
  • range list offsets in .debug_rnglists
  • location list offsets in .debug_loclists
  • indexed forms (DW_FORM_strx*, DW_FORM_addrx*, DW_FORM_rnglistx, DW_FORM_loclistx)
  • indexed operations (DW_OP_addrx, DW_OP_constx)
  • indexed addresses in range list entries
  • indexed addresses in location list entries

@philipc philipc requested a review from fitzgen January 14, 2019 09:33
@philipc philipc mentioned this pull request Jan 14, 2019
Closed
@coveralls
Copy link

coveralls commented Jan 14, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 87.393% when pulling 280863c on philipc:index into 6de997b on gimli-rs:master.

fitzgen
fitzgen approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @philipc :)

src/read/cfi.rs Show resolved Hide resolved
src/read/addr.rs Outdated Show resolved Hide resolved
src/read/addr.rs Outdated Show resolved Hide resolved
src/read/loclists.rs Show resolved Hide resolved
src/read/rnglists.rs Show resolved Hide resolved
src/read/reader.rs Show resolved Hide resolved
@philipc philipc merged commit 00cfd6e into gimli-rs:master Jan 15, 2019
@philipc philipc deleted the index branch January 15, 2019 03:01
@philipc philipc mentioned this pull request Feb 1, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipc @coveralls @fitzgen