-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement addr2line #47
Conversation
That would be great. I don't know if we can add modules to Maybe we should factor it out into a new crate and do it Right (unless some other crate abstracting obj files already exists that seems good enough).
Yes, it is on my TODO list to make a method on |
@@ -15,6 +15,7 @@ version = "0.6.0" | |||
[dependencies] | |||
byteorder = "0.5.3" | |||
leb128 = "0.2.1" | |||
getopts = "0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be under [dev-dependencies]
, which are only included for tests and examples.
http://doc.crates.io/specifying-dependencies.html#development-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
b257f2a
to
a65de63
Compare
This is ready for another pass, @fitzgen. |
} | ||
} | ||
|
||
return u64::from_str_radix(string, 16).expect("Failed to parse address"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: rust style is to leave out return
and the semicolon when in tail position.
It's not just functions either. Rust's block "statements" will evaluate to their last expression, if you drop the semicolon, eg:
let foo = {
bar();
1
};
assert_eq(foo, 1);
Same for if
s, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I know this, but it's a hard impulse to break ;) Thanks for the reminder.
Ok, I left a bunch of comments, but they are all very nit picky. Consider it an r=me with comments. I'll merge as soon you update. Thanks! |
If github isn't sending you emails when I overwrite commits, this is ready to merge @fitzgen. |
Huh, I'm not getting those emails. |
Thanks again! |
np, I'm learning a lot from your reviews :) |
This definitely isn't ready for merging yet, but it might be ready to look at.
Notable todos: