Add a name_to_register routine to convert names into register numbers #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
requested changes
Aug 29, 2020
There was a problem hiding this comment.
I suspect that this is not really what you want.
- do you want
RAto be a register name? - how are you going to handle
rax/eax/ax/ah/al? - how are you going to handle synonyms for ARM register names?
I haven't looked at what gdb/lldb do, but you may not even want to use the DWARF register numbers in user interface code. One of the other register numbering schemes might be better (e.g. ptrace or your assembler/disassembler).
src/arch.rs
Outdated
| @@ -19,6 +19,16 @@ macro_rules! registers { | |||
| _ => return None, | |||
| } | |||
| } | |||
|
|
|||
| /// Converts a register name into a register number. | |||
| pub fn name_to_register(value: &'static str) -> Option<Register> { | |||
There was a problem hiding this comment.
Suggested change
| pub fn name_to_register(value: &'static str) -> Option<Register> { | |
| pub fn name_to_register(name: &str) -> Option<Register> { |
nbaksalyar
force-pushed
the
convert-string-into-register
branch
from
50438cd
to
2421d01
Compare
Yes, more likely these are going to be used only as helper methods and not directly in the UI code. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a converse of
register_name, i.e. a function that converts a string register name into a register number. It's useful for debugger command-line interfaces.Please let me know if this needs a test case.